me, 2.0: bug hunting: openafs (2, 3)

me, 2.0: jose nazario beauty and the street

bug hunting: openafs (2, 3)

more typos in OpenAFS, not security bugs. (so why do i post them? to help others use google codesearch to find similar bugs. about 5% of the bugs i've found have security implications.)

bug 1:

--- osi_inode.c.orig    Sat Oct  7 08:50:03 2006
+++ osi_inode.c Sat Oct  7 08:50:10 2006
@@ -125,7 +125,7 @@
        register struct vnode *vp;
        register struct mount *mp;
        extern struct mount *rootfs;
-       if (mp = rootfs)
+       if (mp == rootfs)
            do {
                /*
                 * XXX Also do the test for MFS

bug 2:



--- cm_utils.c.orig     Sat Oct  7 09:26:22 2006
+++ cm_utils.c  Sat Oct  7 09:27:20 2006
@@ -332,7 +332,7 @@
         }

         lock_ObtainWrite(&cm_utilsLock);
-       if (tsp = cm_spaceListp) {
+       if (tsp == cm_spaceListp) {
                cm_spaceListp = tsp->nextp;
         }
         else tsp = (cm_space_t *) malloc(sizeof(cm_space_t));

both filed, but i'm not sure if they've confirmed and/or fixed.

next Saturday, Oct 07, 2006 @ 03:10pm | previous Saturday, Oct 07, 2006 @ 03:05pm | archives

Last modified: Saturday, Oct 07, 2006 @ 03:08pm

Your Ad Here