[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch:] restore the native use of isdigit() instead of ap_isdigit() in httpd.
- To: tech_(_at_)_openbsd_(_dot_)_org
- Subject: Re: [Patch:] restore the native use of isdigit() instead of ap_isdigit() in httpd.
- From: joerg_(_at_)_britannica_(_dot_)_bec_(_dot_)_de
- Date: Thu, 30 Mar 2006 14:41:37 +0200
- Mail-followup-to: tech_(_at_)_openbsd_(_dot_)_org
On Thu, Mar 30, 2006 at 03:08:11AM -0500, Daniel Ouellet wrote:
> Here is a patch to restore the use of the native isdigit() instead of
> the ap_isdigit one.
Have you checked that the arguments are always from the unsigned char
domain? Even though OpenBSD's isdigit handles it internally, it is more
efficient when the compiler can drop one conditional.
Joerg
Visit your host, monkey.org