[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: small source code beautification



yes, I fixed that efore I committed

* Jacob Meuser <jakemsr_(_at_)_jakemsr_(_dot_)_com> [2005-05-15 23:41]:
> On Sun, May 15, 2005 at 04:10:07PM +0200, Toni Mueller wrote:
> 
> > Below you find the updated patch which should now be KNF-clean, with
> > all the advice given heeded (hopefully).
> 
> > @@ -343,11 +328,8 @@
> >  }
> >  
> >  struct radix_node *
> > -rn_insert(v_arg, head, dupentry, nodes)
> > -	void *v_arg;
> > -	struct radix_node_head *head;
> > -	int *dupentry;
> > -	struct radix_node nodes[2];
> > +rn_insert(void *v_arg, struct radix_node_head *head,
> > +	  int *dupentry, struct radix_node nodes[2])
> >  {
> >  	caddr_t v = v_arg;
> >  	struct radix_node *top = head->rnh_treetop;
> 
> since style(9) is being discussed, shouldn't long statemets that need
> two or more lines use a 4 space indent on the second and subsequent
> lines?
> 
> -- 
> <jakemsr_(_at_)_jakemsr_(_dot_)_com>
> 

-- 
BS Web Services, http://www.bsws.de/
OpenBSD-based Webhosting, Mail Services, Managed Servers, ...
Unix is very simple, but it takes a genius to understand the simplicity.
(Dennis Ritchie)