[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Relax dhclient hostname checks



Michael Knudsen wrote:

Note that apart from permitting underscores, the diff also attempts to
improve readability of the code.


[...]

+#define hyphenchar(c) ((c) == '-')
+#define uscorechar(c) ((c) == '_')
+#define bslashchar(c) ((c) == '\\')
+#define periodchar(c) ((c) == '.')
+#define asterchar(c) ((c) == '*')


I think that, if you want to improve readability,
you should kill this useless macro soup entirely.
Cedric



Visit your host, monkey.org