[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: st.c cleanup patch
- To: tech_(_at_)_openbsd_(_dot_)_org
- Subject: Re: st.c cleanup patch
- From: "Joseph C. Bender" <benderjc_(_at_)_benderhome_(_dot_)_net>
- Date: Thu, 20 Jun 2002 07:40:45 -0400
At 12:36 PM 6/20/2002 +0200, Artur Grabowski wrote:
>"Joseph C. Bender" <benderjc_(_at_)_benderhome_(_dot_)_net> writes:
>> I've started some cleanup work in the sys/scsi/st.c driver in prepartation
>> for some feature changes,
>Please, please, please remember that writing code is easy. Reading code is
>hard. You didn't read your diff.
Yes, yes it is. No, no I did not.
Yes, I didn't check my diff. I also violated two major rules of mine last
night when I sent it in:
1. I was tired.
2. I was doing it remotely, and I think I know *why* it wasn't created
right, but I'm not going to go into that, because, while I'm sure it's a
hilarious read, I don't want to waste anymore of anyones time.
These are not excuses, merely a post-mortem.
Yes, I do also know how to spell "acquired", that had been fixed in a patch
generated since 3.1 was released.
And as for not liking splasserts, I do like them, and have nothing against
them <grin>. Seriously, though, this was a major mistake on my part.
This patch was intended to be more of a reformatting than a "bugfix" if you
would, though I consider (IMHO) any time one makes code a little more
readable (theoretically), it's a fix.
I'm sorry for wasting everyones time, esp those who actually do real work
for the project. I will not be so hasty to post a patch in the future.
Thank you to those who provided me constructive criticism off the list.
benderjc (at) benderhome.net
This account is used primarily for reading and responding to mailing list
traffic and is not my main mailing address.
That is: jcbender (at) benderhome.net
Visit your host, monkey.org