[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New Port faac (AAC encoder)

Claudio Jeker <cjeker_(_at_)_diehard_(_dot_)_n-r-g_(_dot_)_com> wrote:

> http://diehard.n-r-g.com/stuff/openbsd/faac.tar.gz

There's an autoconf dependency missing.

If you add "--include-deps" to the automake call in bootstrap,
you'll get portable Makefiles and can remove the gmake dependency.

Remove those CFLAGS/CXXFLAGS assignments from the Makefile.am's,
they are useless and prevent our values from being picked up.
LDFLAGS is abused, too.  (Also try to convince the upstream maintainer
of this.)

In libfaac/util.h, #include <malloc.h> should fetch <stdlib.h>
instead.  And <memory.h> should probably be <string.h>.  (Should
be fixed upstream.  I mean, we're not in the 1980s any longer.)

frontend/input.c is also missing an #include <string.h>.


How am I supposed to use this?

naddy_(_at_)_bardioc[~] faac audio.wav audio.aac        
FAAC version 1.13 (beta) (Dec 20 2002)
Bit rate: 64000 bps per channel
Cutoff frequency is 16000 Hz
Encoding audio.wav
   frame          | elapsed/estim | play/CPU | ETA
Floating point exception (core dumped) 
naddy_(_at_)_bardioc[~] uname -m

Christian "naddy" Weisgerber                          naddy_(_at_)_mips_(_dot_)_inka_(_dot_)_de