[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: quotes in comment lines

Nick Nauwelaerts <nick_(_at_)_wanadoo_(_dot_)_be> wrote:

> the COMMENT line in a port's Makefile should be enclosed by quotes (").

Before this turns into dogma:  The key fact is that bsd.port.mk
uses echo ${COMMENT}, without further quoting.  The most straightforward
way to protect against shell metacharacters and lone apostrophes
is to enclose the whole COMMENT in double quotes.

> However some Makefiles have double quotes in them:
> ./net/nsping/Makefile:COMMENT=  "DNS "ping""
> ./x11/enlightenment/Makefile:COMMENT=   ""themed" window manager"

These are probably the result of an automatic substitution run and
should be fixed.

> Still, shouldn't ports that include quotes in their comments be enclosed
> by ' instead of " ?

I'd prefer if COMMENTs wouldn't resort to using double quotes to
mark irony etc in the first place.

Christian "naddy" Weisgerber                          naddy_(_at_)_mips_(_dot_)_inka_(_dot_)_de

Visit your host, monkey.org