ports subdir Makefiles need cleaning

[Camiel Dobbelaar <cd_(_at_)_sentia_(_dot_)_nl>]

I think the category Makefiles in the ports tree need a good
cleaning. I volunteer for the effort. :-)

By cleaning I mean:

- removing old commented out entries that do not have a port to match,
some left over from the initial import days.

- add entries for ports that did not get added to the Makefile

- alphabetical sort

and the biggest problem:
- syncing the flavors

A lot of flavors are not activated.  While we should not activate every
permutation of flavors for a certain port, I think every flavor should
be activated at least once to be sure it fetches, builds and packages
correctly.
If a certain flavor is not allowed to be packaged, it should be handled by
PERMIT_*,  _not_ by leaving it out of the category Makefile.

I propose that for each flavor that is not accounted for, a single entry
is added to the category Makefile.  The maintainers of individual ports
might choose later to mix-and-match-or-combine certain flavors.

To illustrate my point, here's the 'net' category:

$ grep FLAVORS */Makefile
axyftp/Makefile:FLAVORS=        gtk
bind9/Makefile:FLAVORS=         debug static threads
curl/Makefile:FLAVORS=  kerberos
cvsup-bin-old/Makefile:FLAVORS= no_x11
cvsup-bin/Makefile:FLAVORS=     no_x11
cvsup/Makefile:FLAVORS= no_x11 static
ethereal/Makefile:FLAVORS=      snmp
gated/Makefile:FLAVORS=snmp gii
irc/Makefile:FLAVORS=   ipv6
irssi/Makefile:FLAVORS+=                gettext 
kmago/Makefile:FLAVORS= wget
lftp/Makefile:FLAVORS=  ssl
mtr/Makefile:FLAVORS=        curses
nmap/Makefile:FLAVORS=  no_x11
nslint/Makefile:FLAVORS=                static
popa3d/Makefile:FLAVORS=        apop
pptp/Makefile:FLAVORS+= bbaa
publicfile/Makefile:FLAVORS=    compat
rrdtool/Makefile:FLAVORS=       tcl
snort/Makefile:FLAVORS= postgresql mysql smbalert flexresp
ytalk/Makefile:FLAVORS= no_x11
zebra/Makefile:FLAVORS= snmp

(side note: irssi and pptp use += to set FLAVORS)

$ grep , Makefile
     SUBDIR += curl,kerberos
     SUBDIR += cvsup,no_x11
     SUBDIR += cvsup,static
     SUBDIR += cvsup,static,no_x11
     SUBDIR += cvsup-bin,no_x11
     SUBDIR += cvsup-bin-old,no_x11
     SUBDIR += nmap,no_x11
     SUBDIR += nslint,static
     SUBDIR += popa3d,
     SUBDIR += popa3d,apop
     SUBDIR += publicfile,compat
     SUBDIR += rrdtool,tcl

axyftp, bind9, ethereal, gated, irc, irssi, kmago, lftp, mtr, snort,
ytalk and zebra flavors do not get built.


Comments?

--
Cam