Re: Patch and new file, machdep.c,files.i386,k7-powenow.c, adds k8-powernow.c

[Ted Unangst <ted_(_dot_)_unangst_(_at_)_gmail_(_dot_)_com>]

On 10/21/05, Gordon Willem Klok <gklok_(_at_)_cogeco_(_dot_)_ca> wrote:
> Thorsten Glaser wrote:
> > Gordon Willem Klok dixit:
> >
> >
> >>#define MSR_AMDK7_FIDVID_CTL          0xc0010041
> >>#define MSR_AMDK7_FIDVID_STATUS               0xc0010042
> >>
> >>/* Bitfields used by K8 */
> >
> >
> > Can't that be merged into powernow-k7.c ?
> Those values are also found in powernow-k7.c with a few other
> shared bits, the FreeBSD guys have their driver for both the
> K7 and K8 powernow features integrated into one file, I didn't
> think this was the appropriate way to do this, let me explain
> myself, first mixing the code makes it a lot messier (IMHO),
> second the K7 platform should remain pretty static since there
> wont be a new generations of product derived from that
> architecture, and it was my hope when I ported there code that
> powernow-k8.c eventually finds its way into the AMD64 port
> which as the file exists now wont need any of powernow-k7.c
> and finally well there are a lot of similarities between the
> two there are also big  differences e.g. the way in which a
> fid/vid transition is undertaken.

this is good.  if they are different, then they should remain different.