Re: user/5061: wrong attribute type in usr.bin/banner/banner.c

["Ted Unangst" <ted_(_dot_)_unangst_(_at_)_gmail_(_dot_)_com>]

The following reply was made to PR user/5061; it has been noted by GNATS.

From: "Ted Unangst" <ted_(_dot_)_unangst_(_at_)_gmail_(_dot_)_com>
To: tai_(_dot_)_stoeck_(_at_)_web_(_dot_)_de
Cc: gnats_(_at_)_openbsd_(_dot_)_org
Subject: Re: user/5061: wrong attribute type in usr.bin/banner/banner.c
Date: Wed, 29 Mar 2006 08:25:33 -0800

 On 3/28/06, tai_(_dot_)_stoeck_(_at_)_web_(_dot_)_de <tai_(_dot_)_stoeck_(_at_)_web_(_dot_)_de> wrote:
 >         In usr.bin/banner/banner.c the declaration of dropit,
 >         which is called only once with a variable of type "char",
 >         wants to get an integer. The type of integer is not needed,
 >         as the values fit easily into char (as the values could not
 >         be bigger than char as dropit is called with a char). I have
 >         posted this some time ago on tech@ and nobody shouted at me,
 >         although nobody replied. I think it has to be char.
 
 i think it's better to just leave it as int, since there's nothing to
 be gained by making it char.  other comments?