[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: user/4606: cpio/pax is not 64 bit arch friendly
- To: bugs_(_at_)_cvs_(_dot_)_openbsd_(_dot_)_org
- Subject: Re: user/4606: cpio/pax is not 64 bit arch friendly
- From: Otto Moerbeek <otto_(_at_)_drijf_(_dot_)_net>
- Date: Wed, 9 Nov 2005 00:55:02 -0700 (MST)
- Cc:
- Reply-to: Otto Moerbeek <otto_(_at_)_drijf_(_dot_)_net>
The following reply was made to PR user/4606; it has been noted by GNATS.
From: Otto Moerbeek <otto_(_at_)_drijf_(_dot_)_net>
To: peter_philipp_(_at_)_freenet_(_dot_)_de
Cc: gnats_(_at_)_openbsd_(_dot_)_org
Subject: Re: user/4606: cpio/pax is not 64 bit arch friendly
Date: Wed, 9 Nov 2005 08:33:19 +0100 (CET)
On Mon, 7 Nov 2005, peter_philipp_(_at_)_freenet_(_dot_)_de wrote:
> >Number: 4606
> >Category: user
> >Synopsis: CRC in CPIO must be 32 bits, not so on 64 bit archs
Your fix looks right. The cpio header has room for a n 8 bytes crc, but
it is encoded in hex. Other formats do not use crc, so they are not affected.
Two small nits inline
> - u_long crc = 0L;
> + u_int32_t crc = 0L;
That should be 0
> - unsigned long crc = 0L;
> + u_int32_t crc = 0L;
Again.
-Otto
Visit your host, monkey.org