Re: XF4 freetype patch

[Herrb Matthieu <matthieu.herrb@laas.fr>]

On 13 Nov 2003, at 02:08, Zvezdan Petkovic wrote:

> The patch that switched off the bytecode interpreter in OpenBSD XF4 
> tree
> is not consistent with the rest of that file (ftoptions.h).  I propose
> the change according to the patch below.  That way #define and #undef
> are used only.  No need to comment out anything.  Besides if the same 
> is
> #defined somewhere else, commented out code will not #undef it.  The
> patch below insures #undef.
>
> Regards,
> -- 
> Zvezdan Petkovic <zvezdan@cs.wm.edu>
> http://www.cs.wm.edu/~zvezdan/
> Index: xc/extras/freetype2/include/freetype/config/ftoption.h
> ===================================================================
> RCS file: 
> /cvs/XF4/xc/extras/freetype2/include/freetype/config/ftoption.h,v
> retrieving revision 1.2
> diff -u -r1.2 ftoption.h
> --- xc/extras/freetype2/include/freetype/config/ftoption.h	2003/09/02 
> 20:14:47	1.2
> +++ xc/extras/freetype2/include/freetype/config/ftoption.h	2003/11/13 
> 01:07:09
> @@ -376,7 +376,7 @@
>    /* By undefining this, you will only compile the code necessary to 
> load  */
>    /* TrueType glyphs without hinting.                                 
>      */
>    /*                                                                  
>      */
> -/* #define  TT_CONFIG_OPTION_BYTECODE_INTERPRETER */
> +#undef TT_CONFIG_OPTION_BYTECODE_INTERPRETER

Sorry, I don't really see the benefit. This is how it's done in the main
XFree86 source tree and we want to keep the diffs at a reasonable 
minimum.
Moreover, in more recent Freetype2 sources there are some other examples
of /* #define TT_BLAH */ constructions in ftoptions.h too.