[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: readdir_r

Jim Rees <rees@umich.edu> writes:

> I'm getting segfaults in readdir_r reading from an iso9660 file system.  It
> looks to me like the memcpy is trying to copy past the end of the buffer.  I
> have attached what I think is the proper fix.  One might argue that it would
> be better to use dp->d_reclen, but iso9660 apparently returns the wrong
> reclen.  Should I commit this?

Looks good. I'd say it's ok to commit.
But it sounds like there is a bug in iso9660. It might be worth looking at
that too.