[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Building XFree86 3.3.6 in -current



Hi Todd,

Sorry I got the reason you changed the Makefile wrong.

 > Now, if the Makefile were re-worked so that 'make build' is to do
 > the same thing as '/usr/src' in that it compiles and attempts to
 > install to /usr/X11R6, please address the following concern I have
 > with this approach:
 > 
 > 	Files in /var/X11/xdm/ are specifically not updated if they
 > 	exist.  Thus we need to remove them by default if we are to
 > 	get a 'real' upgrade during a 'make build'.

Why?   We don't remove the files in /etc when doing a make build
in /usr/src.  That step has to be done by hand.  Isn't it the
same thing?

 > It has been noted that 'contrib' is built with the
 > 'make build' .. well, that's what's necessary with release.

Yes.  Building contrib and installing the current linkkit are GOOD
things.   It's one of the reasons I like using "make build".

 > You can see why I put what is in the Makefile in the Makefile, no?

Todd, this is really a minor issue which has probably already consumed
more time than it is worth.  Let me suggest one small change: add this
comment to the Makefile.

	# Some defaults
	# Note: If you want to "make build" and have the generated code
	# installed "in place" comment out the next two lines (or set
	# DESTDIR=/ in your environment).
	# Warning: parts of /var/X11 will NOT be updated
	RELEASEDIR?=`/bin/pwd`/rel
	DESTDIR?=`/bin/pwd`/dest

	all:

I think that will tell people who want to build "in place"
what to do.  Perhaps there's better wording.

Or do nothing.

// marc