Re: proposed patch to porttest.html

[naddy@mips.inka.de (Christian Weisgerber)]

Jose Nazario <jose@monkey.org> wrote:

> +    <p>Dependency handling is easily verified by removing the stated
> +    dependencies and ensuring the port insists they be installed before
> +    the appropriate stage is attempted.</p>

I don't understand this.

> +	 <li>If there are any <tt>FETCH_DEPENDS</tt> make sure that they are
> +	 correctly handled.

Considering that there is currently exactly one (!) port that uses
FETCH_DEPENDS, we can probably consider it as an obscure case that
doesn't need regular attention.

> +	 <li>Check to ensure that <tt>BUILD_DEPENDS</tt> are correctly
> +	     handled. This includes GNU Bison, for example.

I don't understand this.

> +	 <li>Test for the system respecting the CC and CFLAGS settings by
> +	 setting them to arbitrary values.

Well, _arbitrary_ values won't be particularly helpful.  Come on,
we don't need to spell out how people can test this.

>        <li><i>regress</i>
>          <ul>
>            <li>Check for errors (empty tests means okay).
> +	  <li>Check for correct dependency handling.

This isn't terribly far up on the list of common mistakes either.

> +	 <li>Ensure that the port respects the <tt>LOCALBASE</tt> variable
> +	 by setting it to something other than the default.

Now it won't find its required dependencies any longer and never
reach that later stage where /usr/local is hardcoded.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de