[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new: faad2



On Wed, Nov 13, 2002 at 09:50:43AM -0700, Peter Valchev wrote:
> > I expected some comment about the Makefile; how about doing
> > 
> > post-extract:
> > 	(cd ${WRKDIR} && ln -s faad2 ${DISTNAME})
> > 
> > instead of
> > 
> > WRKSRC=		${WRKDIR}/faad2
> > WRKDIST=	${WRKSRC}
> > 
> > What is considered "best pratice"?
> 
> Just WRKDIST=${WRKDIR}/faad2 ?
Yep.

But, as I answered Bjorn privately, I only focused on whether the code
works and packages correctly or not.

His port is close enough to what we need otherwise, cosmetic changes are
stuff I can do quite easily before committing.