[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dvi2tty submission
Jose Nazario <jose@monkey.org> wrote:
> further feedback requested ... enough people find this useful when they
> do look at it i think its worth including. moreso than l2a, even ...
- Doesn't honor CC/CFLAGS.
- The comment says no license, yet you set PERMIT_* to yes.
- Return type of main() only fixed for one of two programs.
This is pure sloppiness. Cleaning up crappy submissions is no fun,
especially if it is evident that the committer is expected to spend
more time on a port than the submitter ever did.
--
Christian "naddy" Weisgerber naddy@mips.inka.de