[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new port: QCad



On Thu, 2 Aug 2001, Christian Weisgerber wrote:

> - Do not hardwire CFLAGS and CXXFLAGS.  Makefiles can of course add to
>   those variables, in particular -D, -I, -L, but they must no overwrite
>   them.

Could the above be actually rewritten as: "Don't override any
variables unless you really have to; use += if you just want to
add something. If you have to, please write a comment specifying
why."

Some things that pop first into mind are CONFIGURE_ENV, MAKE_ENV,
COPTS/CXXOPTS in addition to CFLAGS and CXXFLAGS, PATCH_*ARGS, ...

> - Do not hardwire "/usr/local" and "/usr/X11R6".  Refer to PREFIX
>   for the prefix the current port will install into, LOCALBASE for
>   the prefix of previously installed ports, and X11BASE for the X11
>   prefix.

Haa! Here it is. Seems like I didn't read all of my mail after all
before sending my last e-mail about PREFIX/LOCALBASE. Please ignore it.

-- 
<---------------------------------------------------------------------->
          Heikki Korpela -- heko@iki.fi -- http://iki.fi/heko/