[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ports/94725: [PATCH] Update net/py-ldap2 to 2.0.11



Additionally this patch should be placed into files/ directory in
order to elminate a memory leak:

Index: LDAPObject.c
===================================================================
RCS file: /cvsroot/python-ldap/python-ldap/Modules/LDAPObject.c,v
retrieving revision 1.72
diff -u -r1.72 LDAPObject.c
--- Modules/LDAPObject.c	11 Mar 2006 21:05:57 -0000	1.72
+++ Modules/LDAPObject.c	23 Mar 2006 21:48:33 -0000
@@ -971,8 +971,16 @@
     if (pmsg == NULL) {
 	    retval = NULL;
     } else {
-        retval = Py_BuildValue("(OOiO)", result_str, pmsg, res_msgid,
-			       pyctrls ? pyctrls : PyList_New(0));
+	if (pyctrls != NULL) {
+        	retval = Py_BuildValue("(OOiO)", result_str, pmsg, res_msgid,
+				       pyctrls);
+	} else { 
+		PyObject *pNewList = PyList_New(0);
+        	retval = Py_BuildValue("(OOiO)", result_str, pmsg, res_msgid,
+				       pNewList);
+		Py_DECREF(pNewList);
+	}
+
 	if (pmsg != Py_None) {
         Py_DECREF(pmsg);
     }


Note that this patch was submitted to the original author but got
response.

Cheers,
_______________________________________________
freebsd-ports-bugs_(_at_)_freebsd_(_dot_)_org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe_(_at_)_freebsd_(_dot_)_org"


Visit your host, monkey.org