Re: Carp Suppression

["PSI, Mike Smith" <mlsmith_(_at_)_mitre_(_dot_)_org>]

Hey all,

Honestly I have no idea what this is all about, but saw something in the
change adding "ipf->if_flags=LINK_STATE_UP;" that just seemed really strange
from a programming standpoint. Doesn't this statement "undo" the effects of
the line just before it (ipf->if_flags |= IFF_RUNNING).

Again I have no idea what this is about so it is possible that IFF_RUNNING
bit(s) is part of LINK_STATE_UP bit(s). Just seemed strange and if this is a
problem, catching it early is better than late.

If it is correct as stands, I apologize for questioning it.

Mike Smith


>----- Original Message ----- 
>From: "Josh Kayse" <josh_(_dot_)_kayse_(_at_)_gmail_(_dot_)_com>
>
> One last comment,
>
> I managed to fix it so that carp runs on the plip interface by adding:
> ifp->if_flags = LINK_STATE_UP;

> Here is the diff:

> diff -Nur /usr.orig/src/sys/dev/ppbus/if_plip.c
/usr/src/sys/dev/ppbus/if_plip.c
> --- /usr.orig/src/sys/dev/ppbus/if_plip.c       Wed Sep 15 11:14:18 2004
> +++ /usr/src/sys/dev/ppbus/if_plip.c    Mon Jun 13 10:05:56 2005
> @@ -359,6 +359,7 @@
>
>             ppb_wctr(ppbus, IRQENABLE);
>             ifp->if_flags |= IFF_RUNNING;
> +           ifp->if_flags = LINK_STATE_UP;
>         }
>         break;



_______________________________________________
freebsd-pf_(_at_)_freebsd_(_dot_)_org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "freebsd-pf-unsubscribe_(_at_)_freebsd_(_dot_)_org"