Re: Massive sound changes / fix (24/32bit pcm support, new sampling rate converter, various fixes)

[Jonathan Noack <noackjr_(_at_)_alumni_(_dot_)_rice_(_dot_)_edu>]

On 07/09/05 16:15, Ariff Abdullah wrote:
> There are few LORs (during boot) with this much integrated es137x
> (which I do believe false positives). Perhaps you can reproduce
> it by enabling WITNESS?
>
> http://staff.mybsd.org.my/skywizard/FreeBSD/sound/LOR/es137x_lor.txt
> (This is slightly outdated, some of it have bean dealt with)

The eschan_setdir method is called with the channel lock held.  We get 
the LOR when we grab the es lock in eschan_setdir.  Looking through the 
code, eschan_setformat, eschan1370_setspeed, eschan1371_setspeed, 
eschan_trigger, and eschan_getptr are called with the channel lock held 
and also grab the es lock.  Is there a path where we try to grab the 
channel lock while holding the es lock?  Why yes, there are at least two 
such paths: eschan_init (sndbuf_alloc -> sndbuf_resize) and 
eschan_setblocksize (sndbuf_resize).  So a deadlock is possible, but it 
seems unlikely.  I'm not sure how to handle this.  This is the same 
basic issue as is present with the via8233 (seen in your LOR directory).

I also see this LOR when detaching:
lock order reversal
 1st 0xc23a2cc0 pcm0 (sound cdev) @ 
/usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/sound.c:706
 2nd 0xc0837760 sndstat (sndstat) @ 
/usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/sndstat.c:256
KDB: stack backtrace:
witness_checkorder(c0837760,9,c08330a8,100,c050c874) at 
witness_checkorder+0x3af
_sx_xlock(c0837760,c08330a8,100,0,c234ca00) at _sx_xlock+0x5c
sndstat_unregister(c2376e00,c25f4700,c08331a6,2c2,c2376e00) at 
sndstat_unregister+0x27
pcm_unregister(c2376e00,c06f75b0,c2376e00,f9771be8,c2376e00) at 
pcm_unregister+0x112
es_pci_detach(c2376e00,c2333850,c06f75b0,961,c08439c0) at es_pci_detach+0x17
device_detach(c2376e00,c08425f0,c2320640,1,c22fb000) at device_detach+0x8f
devclass_delete_driver(c22fb000,c08439c0,0,0,c226edc0) at 
devclass_delete_driver+0xcb
driver_module_handler(c226edc0,1,c08439ac) at driver_module_handler+0xd9
module_unload(c226edc0,0,1fb,c2274d00,3) at module_unload+0x66
linker_file_unload(c2274d00,0,c06c4f26,327,bfbfe890) at 
linker_file_unload+0x276
kern_kldunload(0,f9771d04,8,421,2) at kern_kldunload+0x8d
syscall(3b,3b,3b,3,bfbfedf6) at syscall+0x13b
Xint0x80_syscall() at Xint0x80_syscall+0x1f
--- syscall (444, FreeBSD ELF32, kldunloadf), eip = 0x280c0e63, esp = 
0xbfbfe88c, ebp = 0xbfbfecf8 ---

--
Jonathan Noack | noackjr_(_at_)_alumni_(_dot_)_rice_(_dot_)_edu | OpenPGP: 0x991D8195

Attachment: signature.asc
Description: OpenPGP digital signature