[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Make sure icons is NULL in gnome_app_instance_init()

Package: libgnomeui
Severity: major
Version: GNOME2.2.1 2.3.0
os_details: FreeBSD GNOME Project
Synopsis: [PATCH] Make sure icons is NULL in gnome_app_instance_init()
Bugzilla-Product: libgnomeui
Bugzilla-Component: general
Description of Problem:
gnome-python applications initialize without going throught the full
gnomeui initialization.  Therefore, the default-icon property is not
set.  When a new GnomeApp is initialized, and this property is not set,
the icons pointer will not always be NULL.  On systems, such as FreeBSD
-CURRENT, where extra malloc options have been added for debugging, this
pointer might be garbage after g_object_get.  Therefore, initialize it
to NULL to avoid confusion (and crashes).

Steps to reproduce the problem:
1. Launch a gnome-python app (e.g. meld) after setting malloc options AJ
(abort and junk-fill pointers)
2. Observer:

(Meld:62218): GLib-GObject-WARNING **: gobject.c:946: object class
`GnomeProgram' has no property named `default-icon'

Followed immediately by a seg fault.


Actual Results:
The application will crash.

Expected Results:
The application should not crash.

How often does this happen?
Every time

Additional Information:
A patch will be attached that fixes this problem.