[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HEADS UP: destroy_dev_sched() KPI in the tree



On Thu, Jul 05, 2007 at 05:18:43PM +0300, Danny Braniss wrote:
> 
> > Today, I got re@ permission and committed the destroy_dev_sched() KPI
> > into the tree. As suggested by Nate Lawson, destroy_dev() tries to
> > auto-detect "devdrn" deadlock condition and transforms destroy_dev()
> > from d_close() csw method into destroy_dev_sched(). I together with
> > Peter Holm tried to test the change as thoroughly as possible.
> > 
> > The obvious problematic area are the races between device driver
> > module unload and destroy_dev_sched(). At least smb(4) definitely
> > has that race that shall be worked around by draining events with
> > drain_dev_clone_events() and destroy_dev_drain(&cdevsw); see snp(4)
> > change for example.
> > 
> > Please, report issues caused by the patch to the list with me Cc:ed.
> > Change of autodetection of deadlock in destroy_dev() was made in separate
> > commit for ease of reverting.
> 
> and today I got a chance to check it, and it works for me (iscsi_initiator).

Today, I reverted the part of commit that tried to transform destroy_dev()
from d_close() into destroy_dev_sched(). See kern_conf.c, rev. 1.208.
You shall call destroy_dev_sched() explicitely.

Attachment: pgpm9zokBWese.pgp
Description: PGP signature