[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ks8695_reg.h



Hi Gardner,

On Sat, Sep 23, 2006 at 03:10:07PM -0400, Gardner Bell wrote:
> Hello everyone,
> 
> I'm presently working on the KS8695 registers header file and am
> curious what I should and should not include in this file.  At the
> moment I have included almost every register that the data sheets
> mention.  Is this a good idea, or should I make separate header files
> for things like the UART and memory controller registers?  I've
> included a copy of what I have done so far.  Any help and or
> recommendations you can offer, particularly on my naming conventions is
> most welcome.
> 

Great to hear !
I think defining all the registers is a good thing, as you can't always guess
which one you would use.
If when you'll define each individual bits it becomes to big, you may want to
do a seperate file for the UART, but I think the others can stay here.
Oh and I see nothing wrong with your naming convention :)

Cheers, 

Olivier
_______________________________________________
freebsd-arm_(_at_)_freebsd_(_dot_)_org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arm
To unsubscribe, send any mail to "freebsd-arm-unsubscribe_(_at_)_freebsd_(_dot_)_org"